Refactor react-native example for improved ergonomics #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
refactor/react-native-consumer
branch
from
2362d2c to
f0cd646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this example @twitchard! I'm using it as a reference for a personal project and and it's been super helpful.
I got a little confused by the use of
useEffectto drive connection and mute state because I'm used to seeing a user action map to some kind of change in app state which is then reflected in UI state, rather than an app state change treated as a side effect of a UI state change. This is a small refactor that I think will help folks understand the code and map the patterns to their own code. Feel free to close this if this is inconsistent with the general approach y'all use.